Firstperson shield block animation breaks when Inspirations is loaded with Rats

KnightMiner / Inspirations

Mod adding various smaller features to Minecraft

MIT License

44 stars 18 forks source link

Firstperson shield block animation breaks when Inspirations is loaded with Rats #184

Closed BugmanBugman closed 3 years ago

BugmanBugman commented 3 years ago

Describe the bug Title. Shield-blocking in first person is supposed to look like this However, when those 2 mods are loaded together, it doesn't work.

Screenshots or crash report (if relevant) https://streamable.com/uaw1j0

Versions (please complete the following information):

Minecraft: 1.16.3
Mantle: 1.6.40
Inspirations: 1.2.1.19

Other mods required Rats Citadel (dependency)

KnightMiner commented 3 years ago

This was a weird one. To explain what happened, I override the vanilla shield to make it enchantable. Normally this does not cause issues with the block animation as that is registered after I register my replacement, but Rats ignores Forge registration events causing vanilla to register its properties before my override.

I pushed a commit which fixes this by just registering the property for my override, so at least my code is less fragile. Will be in the next release

KnightMiner commented 3 years ago

Will be fixed in next release. Made a mistake in my fix in 1.2.1.23 (hard to catch as this does not happen in dev)

KnightMiner commented 3 years ago

Fixed in 1.2.1.24