search

KnightMiner / Inspirations

Mod adding various smaller features to Minecraft
MIT License
44 stars 18 forks source link

[Suggestion] Blacklist For Enlightened Bushes #37

Closed ChloeDawn closed 6 years ago

ChloeDawn commented 6 years ago

The reason for this suggestion is that Enlightened Bushes are being generated from Chromatic Foliage's leaves. Firstly, you don't appear to support modded subitems, so only the black (meta 0) chromatic leaves are craftable into enlightened bushes; secondly, this integration results in literally crafting coloured leaves into coloured leaves... And to me that makes no sense. I would appreciate a config to be able to blacklist leaves for cases such as this. For reference to the secondary issue regarding subitems, you can find my Item#getSubItems method here:

https://github.com/SleeplessDevelopment/ChromaticFoliage/blob/e18c564804742ef5adaf52e1e8e0a9ea5afc4c44/src/main/java/net/sleeplessdev/chromaticfoliage/item/ChromaBlockItem.java#L30-L37

If you would like me to open a separate issue regarding subitems, let me know.

Inspirations version: 0.1.3

KnightMiner commented 6 years ago

Sub items were working last I checked, vanilla leaves use them and they work. I'll think about a blacklist, it's not easy due to the way the recipe works though (same logic as the bookshelves so it would be a lot of special casing). In any case, you can just not craft them

ChloeDawn commented 6 years ago

Oh, I see the issue... I don't override Block#getSubBlocks, which is what you are using. I assumed mods wouldn't be using it for a Block with an ItemBlock.

https://github.com/KnightMiner/Inspirations/blob/7084b670118f9d0929934b41e343cc0f387750c9/src/main/java/knightminer/inspirations/library/util/TextureBlockUtil.java#L130

ChloeDawn commented 6 years ago

Fixed subitems issue in 1.12-1.0.2. Should probably leave this issue open for the suggestion itself though, idk.

screenshot

ChloeDawn commented 6 years ago

Update: I hadn't realised until now (now that I can see all of my chromatic variants listed) that your models support custom tinting.. so maybe a blacklist isn't necessary for most edge case mods. This is awesome: cyan tinted dark oak christmas bushes! The only downside is all of the generated bushes for fixed colours include my already coloured ones, but ah well heh.

screenshot

KnightMiner commented 6 years ago

In that case I think I will close this. I cannot think of a good way to add a blacklist without special casing my leaf recipes (which is shared by bookshelves as well), and in any case you do not have to use every leaf type in crafting.