[feature request] make carpets mold to slabs as well as stairs

KnightMiner / Inspirations

Mod adding various smaller features to Minecraft

MIT License

44 stars 18 forks source link

[feature request] make carpets mold to slabs as well as stairs #49

Closed Zygus42 closed 5 years ago

Zygus42 commented 6 years ago

Builds often use slabs and stairs together with full blocks - would be great to have the slabs covered by carpets as well as the adjoining stairs and full blocks,

KnightMiner commented 6 years ago

The reason I did not add support for slabs initally initially is twofold:

When the carpet is lowered onto a slab, none of the carpet's model is in the original bounding box, which is awkward for targeting the carpet. I cannot lower the bounding box as they must exist in the original block.
Adding support for slabs would leave gaps from "slab stairs", which has no easy way to fix. I could arguably add the feature and just state thats an intentional non-feature, but point one still remains.

KnightMiner commented 5 years ago

Looked into this again and decided against it, slabs are just too awkward with the hitbox not matching the physical location anymore