search

KnightMiner / Inspirations

Mod adding various smaller features to Minecraft
MIT License
44 stars 18 forks source link

Can't receive heartbeet when using right-click-to-harvest mods? #56

Closed SeriousCreeper closed 5 years ago

SeriousCreeper commented 6 years ago

Heya,

it seems like if i use mods that let you harvest crops with a right click (such as SimpleHarvest), i don't ever receive any heartbeats. To test this, i went into a creative world, set the randomTick gamerule to 10000, planted a field of beetroots and ran around holding right click with bone meal in my hand. After several minutes i have yet to receive any.

Then i switched to breaking the crops instead and planting seeds again and received heartbeets after a short while. Repeated this a few times to double check.

Is this something that could be added? A config option to determine the drop chance of heartbeets would be great too.

Cheers, SC

KnightMiner commented 6 years ago

It sounds like the mods have implemented right click to not listen to the proper events. The way the drops work is by listening to the HarvestDropsEvent, which is the cleanest way to add extra drops. It is pretty easy for a mod to fire that, Tinkers Construct does so in its right click harvest (for kamas and scythes). You should find heartbeets drop from either of those tools.

Looking at the code for SimpleHarvest, they just get the block drops and never fire the Forge event for me to add more drops, so its a SimpleHarvest bug.

I do think the rate being configurable makes sense. Honestly its a bit on the rare side anyways.

SeriousCreeper commented 6 years ago

Ah that makes sense, thanks. Will report it to the SimpleHarvest mod and see if they wanna change it up. In the meantime i'll try out another harvest mod, thanks!

And yeah i find the heartbeet somewhat rare heh, so the config option would be amazing.

KnightMiner commented 6 years ago

I've made the drop a bit more common and added a config for the drop chance in 3a30b52. In my testing I got roughly two heartbeets per stack of beetroots harvested, which seemed fair.

KnightMiner commented 5 years ago

@Kiyaku did you end up reporting to SimpleHarvest? I'd like to crosslink the issue so I can keep track of it

SeriousCreeper commented 5 years ago

@KnightMiner sorry i never did, i kinda stopped doing much with minecraft shortly after, until yesterday (good timing on asking lol). Will check it out today/this weekend and report to SimpleHarvest.

SeriousCreeper commented 5 years ago

Late, but reported it over here: https://github.com/TehNut/Harvest/issues/12

KnightMiner commented 5 years ago

Closing as the corresponding SimpleHarvest issue is closed.