KnightMiner / Inspirations

Mod adding various smaller features to Minecraft
MIT License
44 stars 18 forks source link

Recipe Registration with oredictionary #81

Closed TimGoll closed 5 years ago

TimGoll commented 6 years ago

Some mods (quark) add different types of wooden trapdoors. You could support them if you'd change your recipe to use instead of the default minecraft one.

KnightMiner commented 6 years ago

I could, but my trapdoor has the texture of the vanilla one, and I'd rather not add another 16 variants per wood type. I'll consider this more

TimGoll commented 6 years ago

Ah yes. Adding 16*5 more trapdoors isn't a good idea. Maybe a config option?

KnightMiner commented 6 years ago

No, something as trivial as this won't be a config option, I just need to consider the best way to handle it. It may involve making a wood type neutral texture as I'll have to solve this before 1.13 anyways

TimGoll commented 6 years ago

this sounds actually pretty good. I can make a texture and a model for you, if you need one

KnightMiner commented 6 years ago

Model I have should be sufficient, but id be happy for a texture. Probably something with no windows since the carpets block it anyways

TimGoll commented 6 years ago

Okay. I'll make a texure. Should it be in the vanilla style? One texture for all the sides? Because I could add an extra side texture if you want to.

TimGoll commented 6 years ago

2018-08-26_11 14 02

What do you think about something so simple like this? It would look prettier if you add a seperate texture for the side.

If you like it, I make a PR

KnightMiner commented 6 years ago

If you think it looks better with a side texture, go ahead. It looks pretty good, though in the PR make sure to add a shaderless screenshot.

TimGoll commented 6 years ago

okay. I'll do it later

KnightMiner commented 5 years ago

Added in 59868a7 which was released in 0.2.2