Separate charged arrow configuration from redstone charge config

KnightMiner / Inspirations

Mod adding various smaller features to Minecraft

MIT License

44 stars 18 forks source link

Separate charged arrow configuration from redstone charge config #95

Closed lambdadog closed 5 years ago

lambdadog commented 5 years ago

It seems like charged arrows are the only thing in this mod that isn't possible to disable without disabling the whole tools module, if there isn't a strong reason for this I'd really like to suggest it be made configurable, since the redstone charge is very helpful to me but I'd really like to avoid things that (to me) feel blatantly non-vanilla like the charged arrows

KnightMiner commented 5 years ago

Disable the redstone charges/charger, it's tied to that config IIRC. Might make sense to separate it though

lambdadog commented 5 years ago

It isn't, according to Line 101 of InspirationsTools.java, it seems to just be undisableable

KnightMiner commented 5 years ago

That is not the charged arrow, that is my generic arrow item which contains charged arrows in case I add more arrows with separate configs. See here for the relevant code to disable the redstone one

lambdadog commented 5 years ago

ah, okay, I see!

Regardless, it would probably be useful to separate the config for the two so I'll leave this open and rename it.