KnightMiner / TinkersComplement

Addon for Tinkers Construct including various mod compatibility features and some features that would not fit in Tinkers Construct itself
7 stars 14 forks source link

cannot remove oredicted recipes from melter #60

Closed mattieboy079 closed 4 years ago

mattieboy079 commented 4 years ago

It could be a stupid question. I wanted to remove the recipe of iron ore (and some other ores). I tried 2 things:

  1. with the OreDict , but I get an error that it uses an IItemStack and not an IOreDictEntry.
  2. with the normal iron ore id , but then the recipe has not been removed.
KnightMiner commented 4 years ago

What exact code are you using to make the script?

mattieboy079 commented 4 years ago

I use zenscript.

mattieboy079 commented 4 years ago

mods.tcomplement.Blacklist.addRecipe(, ); --> results in the iron still be abled to be smelted. mods.tcomplement.Blacklist.addRecipe(, ); --> results in the error i mentioned

mattieboy079 commented 4 years ago

Do you have any idea how to fix this? Because I'm creating an ageing modpack, and I don't want to be able to smelt Iron in the Melter, and I really would like to use the Melter as an early game ore smelter.

KnightMiner commented 4 years ago

Alright, this looks like a misunderstanding of how the melter recipes work. The melter registry has three parts:

For what you are trying to do, there are two steps:

See the following for syntax: https://docs.blamejared.com/1.12/en/Mods/Modtweaker/TComplement/Handlers/Overrides/

mattieboy079 commented 4 years ago

Ok, thank you for your answer, I will try to do this. I will let you know if it worked!

mattieboy079 commented 4 years ago

Okay, so it worked for almost everything, except for the iron and golden horse armor, and for the different tracks which result in liquid iron or gold:

I have used Overrides.removeRecipe(); Overrides.removeRecipe(); And i have blacklisted all of the items above. Have I missed something? Thanks for your help!
KnightMiner commented 4 years ago

Did you add a blacklist entry for those? Rails are a smeltery recipe, they behave the same in the melter. An easy check is to see if the recipe is the same in both the smeltety and the melter, if so blacklist is right.

mattieboy079 commented 4 years ago

Okay, thanks for the tip! But yea, I added a blacklist entry for those items.

KnightMiner commented 4 years ago

How did you add the blacklist entry? Exact script would help

mattieboy079 commented 4 years ago

Overrides.removeRecipe(); Overrides.removeRecipe();

Blacklist.addRecipe(, ); Blacklist.addRecipe(, );

Blacklist.addRecipe(, ); Blacklist.addRecipe(, ); Blacklist.addRecipe(, ); Blacklist.addRecipe(, );

I have imported Overrides and Blacklist ofcourse.

KnightMiner commented 4 years ago

Have you tried a blacklist for all gold or iron? Since those are the ores you are blocking.

mattieboy079 commented 4 years ago

Yep, no items resulting in iron or gold can be smelted in the melter anymore, except for these 6 items

KnightMiner commented 4 years ago

I looked into the integration, and it looks like the blacklist is handled really poorly by modtweaker. To expand upon that, I do not add any crafttweaker integration myself, its all on modtweaker.

The fluid in the blacklist is entirely unused, which makes sense because my blacklist does not handle fluids. I see no reason why the itemstack blacklist recipes would not be working, but I cannot understand the logic behind the integration in CraftTweaker, so maybe that is what broke it. To explain it a bit more, the liquid is entirely unused in Blacklist.addRecipe, except that he uses the liquid size to be the item stack size. The item is all that should matter, and he adds items the same way I do.

So this may be a code bug, as what you are typing should work. However, neither Tinkers Complement or ModTweaker are getting any new 1.12 updates, so if it is a bug, its unlikely to be fixed.

mattieboy079 commented 4 years ago

Okay. Well thanks for your time and answers, I appreciate it! Ill guess I just have to accept it for now.