KnightofStJohn / StockWaterfallEffects

This Kerbal Space Program mod contains config files that give Waterfall effects to the stock engines.
18 stars 5 forks source link

NERV Override conflict with KerbalAtomics, resulting in no effects at all #31

Open paploo opened 2 months ago

paploo commented 2 months ago

I have Restock + Waterfall + StockWaterfallEffects + WaterfallRestock installed, and with the lastest updates I hadn't noticed anything strange.

I then installed Nertea's KerbalAtomics and the NERV engine's effects (sounds + waterfall) disappeared completely.

I did some digging, and it appears this is because the KerbalAtomics changes the engine to have two different modes of operation, which changes the internals of the effects names and module ids to utilize.

In any case, the simplest solution was to alter the first line of StockWaterfallEffects/Mod Configurations/ReStock/WaterfallRestock_overrides/Nerv_Restock.cfg so that the NEEDS block adds an additional !KerbalAtomics to the end, e.g.:

@PART[nuclearEngine]:NEEDS[Waterfall&StockWaterfallEffects&ReStock&!KerbalAtomics]:LAST[StockWaterfallEffects]

While a better solution might be to add additional blocks to your overrides file to implement your effects and waterfall module blocks in a way that is also compatible with KerbalAtomics, the simple change above would provide basic compatibility by reverting to what Nertea had built.