Knio / dominate

Dominate is a Python library for creating and manipulating HTML documents using an elegant DOM API. It allows you to write HTML pages in pure Python very concisely, which eliminate the need to learn another template language, and to take advantage of the more powerful features of Python.
GNU Lesser General Public License v3.0
1.72k stars 108 forks source link

Underscores and aria-* tags #118

Closed chesspac closed 5 years ago

chesspac commented 5 years ago

Hello, All aria-* tags (used for bootstrap, for example) aren't converted when I write through named parameters where '-' are replaced by underscores. The only way I found is to use a dict and call it with **mydict More generally, I have the problem with tags with dashes like 'data-page-size', the second dash wasn't converted.

Isn't there a bug?

Thanks

golightlyb commented 5 years ago

I've made a pull request to the maintainer to fix the problem with aria attributes.

I couldn't reproduce the same problem with "data-page-size". I included a test for this, which passes.

What's your version of dominate? Do you have a code example that demonstrates the problem?

chesspac commented 5 years ago

Sorry for the mistake, a bad reading for my html generated code.