Modernize setuptools support to use pyproject.toml

Knio / dominate

Dominate is a Python library for creating and manipulating HTML documents using an elegant DOM API. It allows you to write HTML pages in pure Python very concisely, which eliminate the need to learn another template language, and to take advantage of the more powerful features of Python.

GNU Lesser General Public License v3.0

1.71k stars 110 forks source link

Modernize setuptools support to use pyproject.toml #184

Closed mgorny closed 12 months ago

mgorny commented 1 year ago

Replace the obsolete setup.py script and setup.cfg configuration file with the modern PEP 621 pyproject.toml metadata. This also implies replacing the custom version/long-description grabbing logic (that is broken with Python 3.12) with the features nowadays built-in in setuptools.

Fixes #172

coveralls commented 12 months ago

coverage: 100.0%. remained the same when pulling 2075f2e8f456ff107c1757ffb349ddbb4ea4d075 on mgorny:pyproj-tom into fe1f71e3a48b8f8d3d2747ae5e6eb5c97c13f29f on Knio:master.

Knio commented 12 months ago

Thanks! but can you try to get the remaining CI passing? I give up for now.

mgorny commented 12 months ago

I can fix 3.12 but FWICS testing against 2.7 is no longer possible with GHA.

mgorny commented 12 months ago

Ok, I think that's as far as we can reasonably get. Python < 3.7 is no longer supported by setuptools even.

Knio commented 12 months ago

Thanks, this seems to work in CI, but I can't actually build a package locally to publish, as it just makes "UNKNOWN"

$ python3 -m build --no-isolation
* Getting build dependencies for sdist...
running egg_info
writing UNKNOWN.egg-info/PKG-INFO
writing dependency_links to UNKNOWN.egg-info/dependency_links.txt
writing top-level names to UNKNOWN.egg-info/top_level.txt
reading manifest file 'UNKNOWN.egg-info/SOURCES.txt
...etc

any ideas?

$ python3 --version
Python 3.9.2
$ python3 -m build --version
build 1.0.3 (/usr/local/lib/python3.9/dist-packages/build)

mgorny commented 12 months ago

Thanks!

chenrui333 commented 11 months ago

Thanks for the PR, any chance cutting off a new release? Thanks!