Added the additional [optional] types to the RMC message including:

Knio / pynmea2

Python library for parsing the NMEA 0183 protocol (GPS)

MIT License

635 stars 223 forks source link

Added the additional [optional] types to the RMC message including: #144

Closed barbacbd closed 2 years ago

barbacbd commented 2 years ago

Mode Indicator
Navigation Status

The tests were added as a single test case with many subcases.

Fix for #118

coveralls commented 2 years ago

Coverage increased (+0.02%) to 98.363% when pulling c9a6ee04dae252326e5556a76aae66f268f3357d on barbacbd:RMC_additional_optional_fields into a0d60b62ab2242af7b3a64c415947eb52a3638a5 on Knio:master.

coveralls commented 2 years ago

Coverage increased (+0.02%) to 98.363% when pulling e9fe97728dc3739f03ed9f5b898174ac765b0a11 on barbacbd:RMC_additional_optional_fields into a0d60b62ab2242af7b3a64c415947eb52a3638a5 on Knio:master.

barbacbd commented 2 years ago

@Knio Any way to add you as a reviewer?

Knio commented 2 years ago

Can you fix the failing tests?

barbacbd commented 2 years ago

@Knio Looks like it is good to go. Apparently I forgot to format the super() call for python2.7

wodny commented 1 year ago

@Knio I think that the new is_valid implementation should contain a warning in a docstring as it causes a regression for multiple device models (eg. modems with GPS) when upgrading from 1.18 to 1.19. It seems that some of the devices always return V for the navigational status as they do not implement it but still return messages in the extended NMEA 4.10 format. For those devices status == "A" seems better.