Knockout-Contrib / KoGrid

A Knockout DataGrid
https://knockout-contrib.github.io/KoGrid/
280 stars 131 forks source link

Could you update koGrid to follow the AMD module specification? #175

Open ericziko opened 11 years ago

ericziko commented 11 years ago

Very impressed with your grid control so far... Very nice work!

I am currently trying to integrate it in a project that relies on require.js and

http://requirejs.org/docs/api.html

You can read about how knockout already follows this standard here

http://knockoutjs.com/documentation/amd-loading.html

If you do this it will make it much easier for others to integrate your code in their projects...

Thanks for the great work

Eric Ziko

davidjsilva commented 11 years ago

@ezBoy I like your suggestion and would definitely make integrating easier because we also use require.js, but until this is supported we just wrap the kogrid script with

define(['jquery', 'knockout'], function ($, ko) {
});

I hear ya though does kinda suck to have to do that every time we upgrade.