KnossosNET / Knossos.NET

Repository for the Knossos.NET launcher, currently in development.
GNU General Public License v3.0
21 stars 10 forks source link

Mod install/modify rework #143

Closed Shivansps closed 5 months ago

Shivansps commented 5 months ago

This is a important change to the mod install and modify system.

In short what was changed:

1) During mod install or modify pkg status was used, this resulted in sometime the package status being changed in the local json from recommended/optional to required sometimes. I seem to remember that my original intention was to revert those values back to their original value before saving the json but it seems i completely forgot about it. Now the pkg status is not changed anymore.

2) Do not longer force a needed pkg to be forced selected. When a pkg was referenced as a dependency the old system marked it as required forcing the checkbox to be selected and disabled, so it could not be unchecked. This behaviour causes problems on some cases so now all pkgs in in that condition will be selected on be default, and the foreground for the checkbox will be orange indicating it is important, and the tooltip will indicate that the pkg is requiered by a mod/pkg.

3) Do not check by default recommended pkg for installed mods during mod modify, this fixes the reported mod modify bug on discord.

4) Add missing delete mod pkg function.

5) Also implement #137 Note: This will only apply for the current mod we are installing and not for potential dependencies of it.