KnossosNET / Knossos.NET

Repository for the Knossos.NET launcher, currently in development.
GNU General Public License v3.0
26 stars 10 forks source link

Add option to skip SystemCMD generation #204

Closed BMagnu closed 3 months ago

BMagnu commented 3 months ago

Having the SystemCMD forced on every mod equally is a huuuuge issue to my workflow. It's fairly often that I need to launch some mods in a non-fullscreen window (typically debug mods to attach debuggers and not lock up my whole desktop in the process), and some other mods in fullscreen (just to play), and then others like the VR mod in yet other configurations. In almost all of these cases, these changes are fix and per mod. Having the option to toggle off the system cmd options allows a user to manually configure this per-mod in the command line, without the need to enable complex per-mod graphics options.

JohnAFernandez commented 3 months ago

Thanks for being willing to work with me to make a version that has to be activated. I just squashed the commits into two main ones, with no further changes from what you saw on your last review. I think if @Shivansps or @notimaginative can give this a quick look, just in case, then we can merge pretty soon.

notimaginative commented 3 months ago

LGTM. I really like the hidden settings thing. That was a great idea.