search

KnossosNET / Knossos.NET

Repository for the Knossos.NET launcher, currently in development.
GNU General Public License v3.0
23 stars 10 forks source link

Fix path writing in browse to build on mac #79

Closed JohnAFernandez closed 8 months ago

JohnAFernandez commented 8 months ago

Waiting for confirmation that this does not interfere on Windows before marking as ready for review.

JohnAFernandez commented 8 months ago

Ok, with Wookie's assistance, it now works on Windows and Mac. Hoping for a Linux test from @notimaginative, but otherwise ready.

notimaginative commented 8 months ago

I only took a quick look but I don't think this is the right way to fix it. The reason being that the .app is the build you want to use and the getting to the internals of it is just so Knossos can have a real file to deal with. And Knossos needs to know the directory the build is in, but with this code that gets worked out to be internal to the .app instead of where the .app itself is located.

So I haven't tested the idea yet but this probably needs to be fixed in FsoBuild() instead. folderPath would be the directory when the .app is (no changes needed, probably), and directExec would be set to what you have path set to in this PR.