search

KnossosNET / Knossos.NET

Repository for the Knossos.NET launcher, currently in development.
GNU General Public License v3.0
23 stars 10 forks source link

Download issue with new Mac builds #85

Closed notimaginative closed 8 months ago

notimaginative commented 8 months ago

As of the Dec 4 nightly Mac builds are available in both x64 and arm64 versions. When installing that nightly kNet will download both of them on an arm64 Mac since both versions are technically valid. Preferably it should only download one of them. Or at the very least ensure that the one version is preferred over the other so that it's not simply up to their order in the json as to which will get used.

I took a quick look at this but fixing it properly seems like it might be a bit more complicated than anticipated without a better understanding of the code. And eventually arm64 Windows is going to have this problem as well so it needs a solid solution.

notimaginative commented 8 months ago

Updating this per comments from ShivanSpS.

The builds are scored and it will run the more appropriate one for the host. So the only real issue is that it downloads both valid builds while only ever using one of them.