search

Knotx / knotx-cookbook

Cookbook for automated Knot.x deployment
http://knotx.io
Apache License 2.0
2 stars 5 forks source link

New name for `custom_logback` #25

Open PiteroS678 opened 4 years ago

PiteroS678 commented 4 years ago

From README.MD I have read that custom_logback flag applies logback.xml from .erb template. I think that it is confusing because it indicates using logback.xml other than shipped with knotx_instance.

Example:

knotx_instance instance_id do
  id instance_id
  custom_logback false
  source [...]
end

When it comes to Code Review - It's confusing for reviewers :(

What about renaming it to generate_logback?:

knotx_instance instance_id do
  id instance_id
  generate_logback false
  source [...]
end