Closed marcinus closed 3 years ago
Merging #207 (ab65506) into master (69d5dfe) will decrease coverage by
0.30%
. The diff coverage is78.98%
.
@@ Coverage Diff @@
## master #207 +/- ##
============================================
- Coverage 92.26% 91.96% -0.31%
- Complexity 2007 2016 +9
============================================
Files 192 192
Lines 7604 7680 +76
Branches 176 183 +7
============================================
+ Hits 7016 7063 +47
- Misses 513 542 +29
Partials 75 75
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...s/action/library/http/options/EndpointOptions.java | 57.00% <38.29%> (-14.66%) |
30.00 <9.00> (+9.00) |
:arrow_down: |
...tx/fragments/action/library/cache/CacheAction.java | 95.91% <100.00%> (+0.08%) |
16.00 <1.00> (ø) |
|
...ents/action/library/http/request/BodyComposer.java | 100.00% <100.00%> (ø) |
12.00 <0.00> (ø) |
|
.../library/http/request/EndpointRequestComposer.java | 100.00% <100.00%> (ø) |
6.00 <1.00> (ø) |
|
...est/placeholders/EndpointPlaceholdersResolver.java | 100.00% <100.00%> (ø) |
7.00 <7.00> (?) |
|
...http/request/EndpointPlaceholdersResolverTest.java | 100.00% <100.00%> (ø) |
19.00 <14.00> (+2.00) |
|
...rary/http/request/EndpointRequestComposerTest.java | 100.00% <100.00%> (ø) |
20.00 <2.00> (+2.00) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 69d5dfe...ab65506. Read the comment docs.
Description
Changes the usage of
PlaceholdersResolver
by disabling removal of not matched placeholders. Additional changes in Knotx/knotx-server-http repositoryMotivation and Context
Fixes #206 Relates to Knotx/knotx-server-http#70
Upgrade notes (if appropriate)
If previous code relied on the assumption that not matched placeholders will be
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.