Knotx / knotx-junit5

JUnit 5 support and extensions for Vert.x projects
https://knotx.io
Apache License 2.0
0 stars 4 forks source link

Allow for Knot.x config overrides when using dynamic (random) ports #14

Closed tMaxx closed 6 years ago

tMaxx commented 6 years ago

Potential breaking changes

  1. See KnotxConfigConcatProcessor and KnotxExtension.createConfig(String[]). This fixes problems found in https://github.com/Knotx/knotx-stack/pull/19, but at the same time changes Knot.x configuration loading behavior. Configuration files will now be loaded into memory, overrides from KnotxWiremockExtension will be applied, and resulting configuration will be provided in-memory to KnotxStarterVerticle. This has a potential to omit some internal logic and assumptions, as found earlier in https://github.com/Cognifide/knotx/pull/440.
  2. Instances of WireMockServer are now recognized by their mock name (be it a field name or parameter name), and as such these names currently have to be unique across all tests. So if two tests use the same mock named mockRepository and run simultaneously, then the mock instance will be reused for both tests, regardless of possible configuration differences between test mocks. Good examples are integration tests in https://github.com/Knotx/knotx-stack/pull/19.