Adding Unit tests to KnotxWiremockExtension & extension fixes - Githubissues

Knotx / knotx-junit5

JUnit 5 support and extensions for Vert.x projects

https://knotx.io

Apache License 2.0

0 stars 4 forks source link

Adding Unit tests to KnotxWiremockExtension & extension fixes #27

Closed tomaszmichalak closed 5 years ago

tomaszmichalak commented 5 years ago

Description

JUnit5 review & fixes & Unit tests.

Motivation and Context

We use JUnit5 in all modules but we see cases that are incorrect. This PR contains Unit tests that define the injection logic.

Upgrade notes (if appropriate)

We need to specify the -parameters compiler option to provide the original parameter name during tests executions.

You need to update your annotations: @KnotxWiremock -> @ClasspathResourcesMockServer @KnotxInject -> @RandomPort

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

tMaxx commented 5 years ago

One additional thing so far: google-java-format formatter was used so far for code styling in this module, consider using it as well for the code you added.