Knotx / knotx-junit5

JUnit 5 support and extensions for Vert.x projects
https://knotx.io
Apache License 2.0
0 stars 4 forks source link

Fixes `RequestUtil` failure verification: assertion error not propagated. #62

Closed tomaszmichalak closed 4 years ago

tomaszmichalak commented 4 years ago

Description

When checking RX failure conditions, errors from assertions are not propagated. Tests give a false positive results.

Motivation and Context

This tool is used in may repositories.

Types of changes

Checklist:


I hereby agree to the terms of the Knot.x Contributor License Agreement.

codecov[bot] commented 4 years ago

Codecov Report

Merging #62 into master will increase coverage by 2.46%. The diff coverage is 97.40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     84.36%   86.82%   +2.46%     
- Complexity      241      261      +20     
============================================
  Files            27       28       +1     
  Lines           921      987      +66     
  Branches         65       65              
============================================
+ Hits            777      857      +80     
+ Misses          106       92      -14     
  Partials         38       38              
Impacted Files Coverage Δ Complexity Δ
...est/java/io/knotx/junit5/util/RequestUtilTest.java 97.14% <97.14%> (ø) 16.00 <16.00> (?)
...rc/main/java/io/knotx/junit5/util/RequestUtil.java 100.00% <100.00%> (+100.00%) 4.00 <2.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e81d679...b9f3a4e. Read the comment docs.