Knotx / knotx-launcher

Launcher provides a way to configure and run bare Knot.x instance.
https://knotx.io
Apache License 2.0
1 stars 0 forks source link

Use try-with-resources instead closeQuietly #38

Closed malaskowski closed 4 years ago

malaskowski commented 4 years ago

Description

Use try-with-resources instead closeQuietly to close StringReader.

Motivation and Context

In Vert.x 3.9.1 closeQuietly was removed, see https://github.com/vert-x3/vertx-config/pull/115.

Types of changes

Checklist:


I hereby agree to the terms of the Knot.x Contributor License Agreement.

codecov[bot] commented 4 years ago

Codecov Report

Merging #38 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage     80.35%   80.35%           
  Complexity      153      153           
=========================================
  Files            17       17           
  Lines           616      616           
  Branches         30       30           
=========================================
  Hits            495      495           
  Misses          105      105           
  Partials         16       16           
Impacted Files Coverage Δ Complexity Δ
...n/java/io/knotx/launcher/config/ConfProcessor.java 63.41% <100.00%> (ø) 4.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ecfc5e...687730f. Read the comment docs.