search

Knotx / knotx-website

Knot.x Website Generator
https://knotx.io
Apache License 2.0
2 stars 11 forks source link

Errors in Configurable API gateway tutorial #59

Closed Mateusz512 closed 5 years ago

Mateusz512 commented 5 years ago
  1. api-gateway.yml is incorrect, since it is referring to the actual structure of https://github.com/Knotx/knotx-example-project repository and not the structure created by following the tutorial: ../common-services/ should be replaced with ./services since the tutorial is telling to create directory services under the root of the project Do we want to change the name of the directory or update api-gateway.yml ?
  2. It would be nice to have one additional info to run docker swarm init before trying to deploy the stack ;)
tomaszmichalak commented 5 years ago

Hi @Mateusz512,

  1. ../common-services/ are used in API Gateway and Template Processing tutorials, you can see gateway-api.yml and template-processing.yml. The @marcinkp intention was to not duplicate those services data. Can we instead update tutorial and mention that we made such improvement?
  2. Please add.

Can you please fix those issues?

Mateusz512 commented 5 years ago

On it!