Knotx / knotx

Knot.x is a highly-efficient and scalable integration framework designed to build backend APIs
https://knotx.io
Apache License 2.0
126 stars 26 forks source link

Knots process only configured Fragments #186

Closed tomaszmichalak closed 7 years ago

tomaszmichalak commented 7 years ago

Overview

This issue is described in https://github.com/Cognifide/knotx/issues/213. This task needs to address all points:

Current behaviour

Currently Action Knot handles all request with "form.*", Service Knot processes all snippets, Handlebars Knot processes all snippets. We should provide more accurate information about fragments - what Knots should be used for particular snippets. There should not be hidden relationship - if there is "form", Handlebars Knot will be used.

We could change this: data-api-type="templating" to data-knot-types="form123, service, handlebars"

This will prevent against untapped processing - for example we could have snippert with form which does not require Service Knot (data-knot-types="form123, handlebars").

malaskowski commented 7 years ago

I like the idea, it may improve request processing performance by e.g. omitting not used knots.

tomaszmichalak commented 7 years ago

Agreed, ready to implement.

tomaszmichalak commented 7 years ago

Fixed.