Closed dkorolev closed 9 years ago
@sompylasar , thank you for the comments on the comments!
I've just fixed all of them, could you please look through again?
Have an idea on how to make the ownership part with Join()
vs. Detach()
clear, will do in the next several hours.
Thanks, Dima
@dkorolev more comments on the commit for the comments.
@sompylasar , @deathbaba : PTAL at OptionallyOwned
.
I got a dinner invite, will blend OptionallyOwned
with Detach()
-ing the listeners in ~4 hours.
Thanks, Dima
@sompylasar, @deathbaba : PTAL. CC @mzhurovich.
Thanks, Dima
The code is too complex for me to get the idea and review it effectively. Can merge it though.
Hi guys, here comes Sherlock.
Done:
Publish()
and half ofSubscribe()
.WaitableAtomic
(this one is from 2014).In progress:
Subscribe()
, since it should take ownership of the passed in processor in case ofdetach()
-ing the thread.Not done, and will not be done until the first demos take place.
@deathbaba, @sompylasar, @mzhurovich : PTAL. As always, user-facing API is my primary concern.
Thanks, Dima