search

KnowSheet / Sherlock

Structured, append-only, immutable data persistence layer with publish-subscribe.
2 stars 1 forks source link

`AsyncCallFunction`+ `ContainerWrapper` with `Get()/Add()` #23

Closed mzhurovich closed 9 years ago

mzhurovich commented 9 years ago

@dkorolev I solved a problem with declval/decltype using a hack with const_cast, but not sure, if it's an optimal solution. Anyway, it finally compiles and passes the tests :) Comments and suggestions are highly appreciated!

mzhurovich commented 9 years ago

@dkorolev A few more changes. PTAL.

dkorolev commented 9 years ago

Very clean! Looking forward to converging tomorrow.

dkorolev commented 9 years ago

Actually, it might be a good idea to merge this pull request before we start the next expand/collapse iteration. I'd be up for it. @mzhurovich , what do you think?

dkorolev commented 9 years ago

@mzhurovich This minor change empowers Yoda with major benefits: https://github.com/dkorolev/Sherlock/commit/e2a8db45ac68604cff4cecac40b352857d553954

EDIT: https://github.com/dkorolev/Sherlock/commit/7b2fb9a47ff7576ff843b0b9b947297b9e9ee386. Forgot that git push -f changes commit hash.

mzhurovich commented 9 years ago

@dkorolev PTAL and maybe merge, if it's ok?