search

KnowSheet / Sherlock

Structured, append-only, immutable data persistence layer with publish-subscribe.
2 stars 1 forks source link

Iris Flowers Demo #28

Closed dkorolev closed 9 years ago

dkorolev commented 9 years ago

@mzhurovich, PTAL.

Mostly as an example and a reference point of what more can/should we simplify API-wise.

Thanks! Dima

dkorolev commented 9 years ago

@sompylasar -- зацени :-)

dkorolev commented 9 years ago

Hi @mzhurovich & @sompylasar

PTAL -- best after https://github.com/KnowSheet/Sherlock/pull/29 is merged.

Thanks! Dima

dkorolev commented 9 years ago

(FTR: The test passes on Mac, but, when running the code for real, the rendering part doesn't have the pngcairo visualizer. Fine for now.)

sompylasar commented 9 years ago

@dkorolev API или библиотека познаётся тогда, когда пытаешься использовать иначе, чем задумал разработчик.

dkorolev commented 9 years ago

@sompylasar Пока всё плюс-минус по назначению, кромe HTML.

dkorolev commented 9 years ago

@mzhurovich PTAL (after https://github.com/KnowSheet/Sherlock/pull/29)

Thanks! Dima

dkorolev commented 9 years ago

Merged changes from https://github.com/KnowSheet/Sherlock/pull/29, this one is ready to look at again!

mzhurovich commented 9 years ago

@dkorolev LGTM++! Need another round of discussions about simple API vs Accessor/Mutator syntax :)

dkorolev commented 9 years ago

Thanks @mzhurovich !

Have a great night -- and talk soon!

Dima

dkorolev commented 9 years ago

@mzhurovich -- please hold on for a sec with this pull request, HTTP subscription got broken.

It's blocking me, and it might be something bigger. Investigating now. Please review https://github.com/KnowSheet/Sherlock/pull/30 in the meantime once you have a minute.

Thanks! Dima

dkorolev commented 9 years ago

Well, obviously -- stream publishing is now temporarily disabled. That explains a lot! Looking into ...

dkorolev commented 9 years ago

@mzhurovich : PTAL at this one as well..

Commits history is f**cked up here; we'll re-create pull request with one commit.

Please take a look -- but don't click "Merge". Thanks! :-)

dkorolev commented 9 years ago

@mzhurovich : I'll re-push this code once the current changes are in. Omitting this pull request now.