Enabling partial subscription to data.

KnowSheet / Sherlock

Structured, append-only, immutable data persistence layer with publish-subscribe.

2 stars 1 forks source link

Closed dkorolev closed 9 years ago

dkorolev commented 9 years ago

@sompylasar : Thanks for the review, PTAL.

dkorolev commented 9 years ago

Could you please look at this one before we merge https://github.com/KnowSheet/Sherlock/pull/8? Thanks!

sompylasar commented 9 years ago

This one is LGTM, we'll have merge conflicts with the comments to class members, I've fixed them another way.

dkorolev commented 9 years ago

Good to merge?

(And I'm working on responding to the same comment from you in another thread.)

sompylasar commented 9 years ago

yes, ~~ship~~ merge it