search

KnowWhereGraph / KWG-SHACL

This is the repository of SHACL shapes development/research for KWG.
1 stars 1 forks source link

review finished for sosa:Actuation and sosa:Actuator. #4

Closed ling-cai closed 2 years ago

ling-cai commented 2 years ago
  1. hasSimpleResult is missing. not sure if this is needed. But in sosa-shacl:ObservationConstraint, this property is added.
  2. please check the modification in each file.
shirlysteph commented 2 years ago

@ling-cai

  1. There is no hasSimpleResult constrains specific to these classes in the standard
  2. What modifications are you referring to - I do not see any comments
ling-cai commented 2 years ago
  1. Yes. Then to be consistent, we may need to suggest removing the added constraints from observationCollectionConstraint.
  2. Click the commit message right after your ttl in github you will see the changes and comments I left.

On Sep 16, 2021, at 2:35 PM, Shirly Stephen @.***> wrote:

There is no hasSimpleResult constrains specific to these classes in the standard What modifications are you referring to - I do not see any comments — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KnowWhereGraph/KWG-SHACL/issues/4#issuecomment-921272081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKTVTEQOWLAJJAOZ45LUBM3UCJPLZANCNFSM5EFU5EYQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ling-cai commented 2 years ago
  1. in ActuationConstraint.ttl, last line : sh:minCount 1 ; -->sh:maxCount 1 ;
  2. shacl:ActuatorConstraint.ttl, there should be a space between ‘atleast’, though a minor issue.
zhurui0509 commented 2 years ago

@shirlysteph We do need hasSimpleResult. This is what we have discussed in the OE meeting: we are not simply doing a one-to-one translation from SOSA ontology (restriction). Having either hasSimpleResult or hasResult, but not both is one of such a example that we are doing more in SHACL beyond one-to-one translation.

Also, for the two errors Ling found, I do not see you have corrected it.

Anyway, I will fix it on my end. Just to keep you informed.

zhurui0509 commented 2 years ago

Fixed all the issues mentioned.