KnowWhereGraph / kwg-faceted-search

Knowledge Explorer: The search interface to KnowWhereGraph
http://stko-kwg.geog.ucsb.edu
3 stars 0 forks source link

Update usages of sosa:phenomenonTime to match KWG-V4 triplification pattern #89

Closed amoeba closed 2 years ago

amoeba commented 2 years ago

It looks like the change in https://github.com/KnowWhereGraph/kwg-seed-graph/issues/226 affects faceted search. Does that sound right, @seilagonzalez? A quick search shows these usages:

; ag phenomenonTime
dr-app/public/js/query.js
335:            ?entity sosa:phenomenonTime ?startTime.
336:            ?entity sosa:phenomenonTime ?endTime.
360:            ?observationCollection sosa:phenomenonTime ?startTime.
361:            ?observationCollection sosa:phenomenonTime ?endTime.
392:            ?observationCollection sosa:phenomenonTime ?time.

scenario-faceted-search.md
121:         sosa:phenomenonTime ?phenomenontime.
seilagonzalez commented 2 years ago

@amoeba I will take a look and ask again if we are using sosa:phenomenonTime or a collection or both.

seilagonzalez commented 2 years ago

no answer, hopefully I can know soon, I will ask in the knowwheregraph channel.

seilagonzalez commented 2 years ago

from Shirly: "sosa:phenomenonTime should only point to ObservationCollection, not Hazard (earthquake event here) @Seila Gonzalez (edited)

Seila Gonzalez 3:00 PM that it should be hazard->OC->PhenomenonTime

Seila Gonzalez 2:58 PM ok for any Hazard correct?"

seilagonzalez commented 2 years ago

@fritosxii so we are aware about this when we switch to V4 if they don't fix this issue in V3

seilagonzalez commented 2 years ago

I think this is right in the staging graph, but leaving this open so it is double checked.

ThomasThelen commented 2 years ago

Tested this on the latest version that's deployed and I believe it's completed. @zilongliu-geo should be able to confirm because I believe he completed this feature.