KnowZero / Krita-PythonPluginDeveloperTools

Python plugin for Krita that assists with making python plugins for Krita
48 stars 2 forks source link

Better console contrast for print() #9

Closed SuzukaDev closed 4 months ago

SuzukaDev commented 5 months ago

The prints in the console tab were very hard to see in dark themes:

imagen

(I've choosen a green because it stills remain "neutral" as blue (or at least is not a warning/error color)).

KnowZero commented 5 months ago

I use dark theme myself and I can see the problem, probably when I was doing that part redshift was on

That said, if this is going to be fixed it should be done properly. And while it is more readable on dark theme, it is less readable on light theme.

And if you test the color here on white, it definitely fails contrast ratio:

https://webaim.org/resources/contrastchecker/

I suggest testing for light or dark theme

qApp.palette().window().color().value() > qApp.palette().windowText().color().value()

And then picking a darker green for the light theme

SuzukaDev commented 5 months ago

You are right, that is better and covers nicely both types of themes.

(Thank you for pointing me in the right direction (I didn't know how to check the palette/theme colors))

Just in case you want to check: For Dark themes 🌙: https://webaim.org/resources/contrastchecker/?fcolor=25DA3D&bcolor=1C1C1C (I used the background color of the darkest krita (default) theme as a base)

Light themes: ☀ https://webaim.org/resources/contrastchecker/?fcolor=094813&bcolor=FFFFFF