Closed justaddcoffee closed 4 years ago
On it!
Reproduced error, working on fixing it.
Fixed, I will close this issue when we will publish the new version. The error was caused by leaving the edge types mapping within the graph with negative edges, which cannot have edge types by definition.
Excellent, thanks @LucaCappelletti94 ! Ping me when the new version is published and I'll unpin this dependency
Does this pass now?
Yep, merged now - thanks @LucaCappelletti94
Describe the bug
In
TestEdges.test_make_edges_pos_train_test_valid_edges_distinct_1_neg_train_edges_tsv
, I'm seeing a panic:To Reproduce
pip install ensmallen_graph -U
pytest test
see also: https://travis-ci.org/github/Knowledge-Graph-Hub/kg-covid-19/builds/730114817
Expected behavior
Should pass holdout unit tests
Version
f012b45f8df0badcda4e3f40836acd082ac97076
Additional context
Also causes problems when loading graphs because my unit tests are using deprecated args in
from_csv
(force_conversion_to_undirected
, possibly others)