search

Knowledge-Graph-Hub / kg-obo

A package to transform all OBO ontologies into KGX TSV format and OBO json, and put the transformed graph in KGhub
https://knowledge-graph-hub.github.io/kg-obo/getting_started.html
GNU General Public License v3.0
28 stars 2 forks source link

Builds failing due to ImportError with `moto` #210

Closed caufieldjh closed 6 months ago

caufieldjh commented 6 months ago

Describe the bug

The last few builds failed due to the following:

04:04:14  + python3.9 run.py --bucket kg-hub-public-data --no_dl_progress --force_index_refresh
04:04:16  Traceback (most recent call last):
04:04:16    File "/var/lib/jenkins/workspace/knowledge-graph-hub_kg-obo_main/gitrepo/run.py", line 11, in <module>
04:04:16      from kg_obo.transform import run_transform
04:04:16    File "/var/lib/jenkins/workspace/knowledge-graph-hub_kg-obo_main/gitrepo/kg_obo/__init__.py", line 4, in <module>
04:04:16      from .transform import retrieve_obofoundry_yaml, kgx_transform, get_owl_iri, track_obo_version, download_ontology, run_transform
04:04:16    File "/var/lib/jenkins/workspace/knowledge-graph-hub_kg-obo_main/gitrepo/kg_obo/transform.py", line 27, in <module>
04:04:16      import kg_obo.upload
04:04:16    File "/var/lib/jenkins/workspace/knowledge-graph-hub_kg-obo_main/gitrepo/kg_obo/upload.py", line 3, in <module>
04:04:16      from moto import mock_s3 # type: ignore
04:04:16  ImportError: cannot import name 'mock_s3' from 'moto' (/var/lib/jenkins/workspace/knowledge-graph-hub_kg-obo_main/gitrepo/venv/lib/python3.9/site-packages/moto/__init__.py)

This is due to moto hitting a new major version: https://github.com/getmoto/moto/blob/master/CHANGELOG.md

So the import statement is now

from moto import mock_aws