Refactor - Githubissues

Knowledge-Graph-Hub / neat-ml

Network Embedding All the Things

BSD 3-Clause "New" or "Revised" License

18 stars 1 forks source link

Refactor #2

Closed justaddcoffee closed 3 years ago

justaddcoffee commented 3 years ago

Start of a refactor to:

move stuff into modules
use a factory pattern for classifiers
tidy up the use of parsed YAML
add code to wrap holdouts

justaddcoffee commented 3 years ago

@deepakunni3 we possibly could chat about this when you have a chance, in case you have some thoughts

deepakunni3 commented 3 years ago

Yes, lets catch up and review this PR

justaddcoffee commented 3 years ago

Okay great @deepakunni3 (to be clear, this isn't much of a PR right now, just thought we should chat so I can get your thoughts on the above proposed changes)

justaddcoffee commented 3 years ago

@deepakunni3 ready for you to have a look - pretty major refactor