pre_run_checks should catch `botocore.exceptions.NoCredentialsError`

Knowledge-Graph-Hub / neat-ml

Network Embedding All the Things

BSD 3-Clause "New" or "Revised" License

18 stars 1 forks source link

pre_run_checks should catch `botocore.exceptions.NoCredentialsError` #55

Closed caufieldjh closed 2 years ago

caufieldjh commented 2 years ago

The pre_run_checks has its check_s3_credentials argument set to True by default, so it always checks for S3 upload details. That's normally not a problem, but when testing locally and S3 credentials aren't available, it raises botocore.exceptions.NoCredentialsError without catching it. If there isn't an upload block, this should behave similarly to an error with existing credentials (i.e., warnings.warn("YAML contains no upload block - continuing")

caufieldjh commented 2 years ago

Fixed by 7c875a03b539dfe084e647ffb688eeb19588b78f