search

Knowledge-Graph-Hub / neat-ml

Network Embedding All the Things
BSD 3-Clause "New" or "Revised" License
18 stars 1 forks source link

Move `graph_path` argument out of `graph_data` arguments #76

Closed caufieldjh closed 2 years ago

caufieldjh commented 2 years ago

As seen in issues like #73, it is problematic to have an additional argument passed to a function expecting to pass all kwargs to Ensmallen. It also complicates LinkML schema design. The graph_path arg can still be optional, but should be provided independent of graph_data.

justaddcoffee commented 2 years ago

thanks, makes sense, and probably will simplify supporting linkML