search

Knowledge-Graphs-Book / HTML-Book

Other
36 stars 7 forks source link

Edge cannot be in the graph and not in the graph simultaneously #57

Closed GiugAles closed 4 months ago

GiugAles commented 5 months ago

Hello everyone,

I stumbled across this while reading the book. I talked to @smnmyr and he suggested to create a PR.

It is stated in the book that:

the set of negative examples to be the set of all edges <?php echo gedge("\(x\)","\(p\)","\(y'\)"); ?> not in the graph but where there exists a node <span class="gnode">\(y\)</span> such that <?php echo gedge("\(x\)","\(p\)","\(y'\)"); ?> is in the graph.

I am suggesting that the second edge should not contain y' but y (no dash)

the set of negative examples to be the set of all edges <?php echo gedge("\(x\)","\(p\)","\(y'\)"); ?> not in the graph but where there exists a node <span class="gnode">\(y\)</span> such that <?php echo gedge("\(x\)","\(p\)","\(y\)"); ?> is in the graph.
Antoine-Zimmermann commented 5 months ago

Good catch, @GiugAles! Personally, I find odd that $y'$ is introduced before $y$, so I would instead propose:

the set of negative examples to be the set of all edges <?php echo gedge("\(x\)","\(p\)","\(y\)"); ?> not in the graph but where there exists a node <span class="gnode">\(y'\)</span> such that <?php echo gedge("\(x\)","\(p\)","\(y'\)"); ?> is in the graph.