search

KnowledgeCanvas / knowledge

Knowledge is a tool for saving, searching, accessing, exploring and chatting with all of your favorite websites, documents and files.
Apache License 2.0
1.32k stars 92 forks source link

[Bug]: Project disappears in tree on drag-and-drop #50

Closed RobRoyce closed 2 years ago

RobRoyce commented 2 years ago

Describe the bug On occasion, performing a drag-and-drop operation to move one project into another (as a subproject) results in an incomplete tree, even though the project is moved successfully. For instance, given the following project structure:

- Project_1
- Project_2
  - Project_3

Dragging Project_3 into Project_1 may result in:

- Project_1
- Project_2

However, going to Project_1 and clicking the breadcrumb shows that Project_3 is, in fact, a subproject of Project_1. Therefore, the move works as expected, but the project tree is not sufficiently updated in the process.

To Reproduce Steps to reproduce the behavior:

  1. Open the project tree (cmd/ctrl + p)
  2. Drag a project (or subproject) onto another project in the tree

Note: it does not happen consistently and I am unable to determine what specific scenarios lead to the issue.

Expected behavior Using the example above, you would expect to see a final project tree of:

- Project_1
  - Project_3
- Project_2

Screenshots If applicable, add screenshots to help explain your problem.

The first screenshot shows the project tree after moving a project titled HPC into the project HPC CUDA JupyterHub. The second screenshot shows the breadcrumb dropdown of the latter and indicates that the move was successful.

Screen Shot 2022-05-13 at 10 38 46 AM

Screen Shot 2022-05-13 at 10 40 33 AM

Operating System (please complete the following information):

RobRoyce commented 2 years ago

Disabled drag-and-drop in the project tree in #65. Will implement new method for moving projects that does not rely on drag-and-drop.