KnowledgeCanvas / knowledge

Knowledge is a tool for saving, searching, accessing, exploring and chatting with all of your favorite websites, documents and files.
Apache License 2.0
1.32k stars 92 forks source link

[Bug]: Escape key closes import dialog #51

Closed RobRoyce closed 2 years ago

RobRoyce commented 2 years ago

Describe the bug Pressing the esc key closes the modal import dialog, even if the active focus is not on the import dialog itself (e.g. pressing the info button on a card in the dialog and pressing esc when the info window is visible).


To Reproduce Steps to reproduce the behavior:

  1. Press the + button
  2. Add a Knowledge Source
  3. Click the info button on the Knowledge Source
  4. Press esc
  5. This action closes both the info dialog and the import dialog

Expected behavior The previous sequence should only close the info dialog and not the import dialog. Or, at a minimum, the user should be prompted to confirm closing the import dialog when there is at least one Knowledge Source waiting to be imported.


Operating System (please complete the following information):

RobRoyce commented 2 years ago

New design resolves the issue.