search

KnowledgeCanvas / knowledge

Knowledge is a tool for saving, searching, accessing, exploring and chatting with all of your favorite websites, documents and files.
Apache License 2.0
1.32k stars 92 forks source link

[Bug] Renaming a subproject with a 3 letter name doesn't work #90

Closed NxDs closed 1 year ago

NxDs commented 1 year ago

If you try to rename an already existing project to a 3 letter name it doesn't work, it shows no notification (showing debug level notifications) and doesn't save the changes.

Creating a 3 letter name new project works fine

NxDs commented 1 year ago

My guess is that this line is the issue as it checks if the name length is <= 3 instead of just < 3 https://github.com/KnowledgeCanvas/knowledge/blob/main/src/kc_angular/src/app/components/project-components/project-info.component.ts#L171 There's one in ks-info.component.ts as well that checks <= 3 as well, perhaps that's also not right

RobRoyce commented 1 year ago

Good catch, fix will be included in release/0.7.1!