search

KnpLabs / ConsoleServiceProvider

A Console service provider for Silex
MIT License
107 stars 37 forks source link

Convert to a Pimple ServiceProvider #10

Closed rmasters closed 8 years ago

rmasters commented 10 years ago

Makes this service provider accessible on any Pimple-based app - Silex, Cilex, etc.

I'm 90% sure this is right (it works in Silex/Cilex at least) - would like someone to confirm though.

Nek- commented 10 years ago

:+1: the project should be tag before merging this PR. It's a BC Break isn't it ?

rmasters commented 10 years ago

Yeah that'd be a good idea.

jmleroux commented 9 years ago

A similar Pimple Service Provider exists : https://github.com/Cilex/console-service-provider

flip111 commented 9 years ago

duplicate of https://github.com/KnpLabs/ConsoleServiceProvider/pull/8

silverpark commented 9 years ago

Hi,

Where are changes on master branch ?

I need merge this please without fork

Regards,

flip111 commented 9 years ago

@silverpark this repo seems not maintained anymore. Perhaps try this https://github.com/Cilex/console-service-provider

silverpark commented 9 years ago

Thank you very much ;)

ghost commented 8 years ago

I think we can close this now

flip111 commented 8 years ago

@CrimsonLabs if you want this provider to stay @ silex 1.* and slowly die yes. https://github.com/Cilex/console-service-provider will probably serve for silex 2.0 projects. Normally it's better to have some healthy package competition though :) Why not make a tag like suggested by @Nek- ?

ghost commented 8 years ago

No worries - I'm going to work on a split in the next few days.

ghost commented 8 years ago

Please see version 2.0, this resolves the issue.