Fixed bug: boot the Application when run has executed

KnpLabs / ConsoleServiceProvider

A Console service provider for Silex

MIT License

107 stars 37 forks source link

Fixed bug: boot the Application when run has executed #12

Closed liuggio closed 8 years ago

liuggio commented 9 years ago

The problem is that if you boot the silex application in the constructor some other providers won't work

weaverryan commented 9 years ago

Hey @liuggio!

I think this repo may not be maintained at all anymore - no commits for 2 years. I've never used this myself - I just didn't want your PR to go without at least some attention (even if my comment isn't very helpful!)

ghost commented 8 years ago

This seems correct to me, and works as intended.

weaverryan commented 8 years ago

I agree. But what if a Command accesses calls the getSilexApplication from inside configure()? Will the app be booted by then with this method?

ghost commented 8 years ago

Yeah - good point!