search

KnpLabs / ConsoleServiceProvider

A Console service provider for Silex
MIT License
107 stars 37 forks source link

Missing typing and relationships #20

Closed gander closed 8 years ago

ghost commented 8 years ago

I don't see any valid reason to have the Application getter and setter in here. The parent class has these methods and adding them here adds no value to the application.

weaverryan commented 8 years ago

Yea, I agree - @gander, unless you can tell us why you added those, then I think we should close this.

ghost commented 8 years ago

I think we can close this