search

KnpLabs / ConsoleServiceProvider

A Console service provider for Silex
MIT License
107 stars 37 forks source link

Silex 2.* update #8

Closed flip111 closed 8 years ago

flip111 commented 10 years ago

Makes ConsoleServiceProvider compatible with Silex 2.*

ghost commented 8 years ago

@flip111 is this backwards compatible to Silex 1.*?

flip111 commented 8 years ago

Pretty sure it's not.

Other Silex provider packages which i saw had to release an explicit version for silex 2.0

ghost commented 8 years ago

Good Idea - thanks @flip111 I'll be looking into this.

ghost commented 8 years ago

This works 100% correctly in Silex 2. It has my vote. We should probably just release a version 2 which supports Silex 2, and version 1 can stay with Silex 1.

lplume commented 8 years ago

great news! Thanks @flip111 about the patch @CrimsonLabs lets us know about the version. Nice works guys!