KnpLabs / DictionaryBundle

Are you often tired to repeat static choices like gender or civility in your apps ?
MIT License
86 stars 24 forks source link

Allows symfony 6 #155

Closed szappacosta closed 2 years ago

szappacosta commented 2 years ago

breaking change: disallow symfony 4 for 5.4 LTS

szappacosta commented 2 years ago

@AntoineLelaisant @PedroTroller Hello french fellows, i'm having troubles fixing the type hinting error, since the interface is different between symfony 5.4 and 6.0 what it's the way to fix that ?

PedroTroller commented 2 years ago

:hand: It's because Symfony 6 is not compatible with php 7.4 anymore and it's using the mixed type. So I think we should drop support of php 7 to to be compatible with Symfony 6.

szappacosta commented 2 years ago

✋ It's because Symfony 6 is not compatible with php 7.4 anymore and it's using the mixed type. So I think we should drop support of php 7 to to be compatible with Symfony 6.

Thanks, i'll go forward this way.

szappacosta commented 2 years ago

@PedroTroller Hello, i'm stuck again, i don't know if the phpspecs have to be updated, or if there is something else wrong in my symfony 6 update.

szappacosta commented 2 years ago

@PedroTroller Ping =)

PedroTroller commented 2 years ago

@szappacosta I've fixed the specs : https://github.com/KnpLabs/DictionaryBundle/pull/156 You an rebase and retry.

PedroTroller commented 2 years ago

BTW, why have you dropped support of Symfony 5.4 ?

szappacosta commented 2 years ago

@PedroTroller Fixed, sadly you cannot use php 8.1 for development some dev dependencies requires 8.0.* It was a mistake to drop the symfony 5.4.

szappacosta commented 2 years ago

@PedroTroller ready for review =)

PedroTroller commented 2 years ago

:+1: thanks

phpspec will be compatible with php 8.1 really soon, so migration to php 8.1 will be possible

szappacosta commented 2 years ago

@PedroTroller Hello, what is the tagging policy on this project ? Is it possible to tag master to enjoy the new updates ? =

PedroTroller commented 2 years ago

If you use the ^3.2@dev constraint, you will use the master branch.