fix(phpstan): allow PHPStan to run over Translatable/Translation interfaces, close #588

KnpLabs / DoctrineBehaviors

Doctrine2 behavior traits that help handling Blameable, Loggable, Sluggable, SoftDeletable, Uuidable, Timestampable, Translatable, Tree behavior

http://knplabs.com

MIT License

914 stars 294 forks source link

fix(phpstan): allow PHPStan to run over Translatable/Translation interfaces, close #588 #589

Closed Kocal closed 4 years ago

Kocal commented 4 years ago

Fix #588

@TomasVotruba There are some PHPStan issues Do not use "$entityManager->getRepository()" outside of the constructor of repository service but are not related to this PR. They were already present in master.

I've also configured ECS and Rector to run over utils directory. What do you think?

TomasVotruba commented 4 years ago

There are some PHPStan issues Do not use "$entityManager->getRepository()" outside of the constructor of repository service but are not related to this PR.

I see. Could you exclude it now in phpstan.neon so we have passing CI? I'll look on that in near future

TomasVotruba commented 4 years ago

I've also configured ECS and Rector to run over utils directory. What do you think?

Purfect :clap:

TomasVotruba commented 4 years ago

Otherwise, it looks good to me :+1:

Kocal commented 4 years ago

The error has been ignored

TomasVotruba commented 4 years ago

Thanks :+1: