TreeNodeMethodsTrait must be compatible with TreeNodeInterface

KnpLabs / DoctrineBehaviors

Doctrine2 behavior traits that help handling Blameable, Loggable, Sluggable, SoftDeletable, Uuidable, Timestampable, Translatable, Tree behavior

http://knplabs.com

MIT License

914 stars 294 forks source link

TreeNodeMethodsTrait must be compatible with TreeNodeInterface #603

Closed maxhelias closed 3 years ago

TomasVotruba commented 3 years ago

Could you add failing test to show the bug you have before this changes? So we know we have it covered and it won't happen again

maxhelias commented 3 years ago

In fact, we don't have a php error but PhpStorm raise a warning Capture d’écran 2020-10-27 à 13 41 48

TomasVotruba commented 3 years ago

It might be bug in PHPStorm resolution then.

The self in interface = the interface itself, so PHP code is correct here

maxhelias commented 3 years ago

Yes and no, as they are a php trait we would need more a way to link it with this interface. I did'nt find anything on the phpdoc level.

TomasVotruba commented 3 years ago

Hi, I'm going through old opended issues and PRs to cleanup too-long-opened items and close them. Thank you for your contribution and time.

We needs a feature with test and passing CI to be able to merge it without letting a bug in. If this is still relevant for you, please add code with test and make CI pass first. Then we'll able to merge your feature without further waiting :+1:

Thank for understanding.