search

KnpLabs / DoctrineBehaviors

Doctrine2 behavior traits that help handling Blameable, Loggable, Sluggable, SoftDeletable, Uuidable, Timestampable, Translatable, Tree behavior
http://knplabs.com
MIT License
911 stars 287 forks source link

Symfony Uuid vs Ramsey Uuid #633

Closed mkalisz77 closed 2 years ago

mkalisz77 commented 3 years ago

Hi,

As now Symfony has his own Uuid/Ulid component ( https://symfony.com/blog/new-in-symfony-5-2-doctrine-types-for-uuid-and-ulid) maybe ramsey / uuid should be replaced by standard Symfony library?

Regards, Michal Kalisz

TomasVotruba commented 3 years ago

Hi,

that might break some stuff and force people to switch. How can we allow both and let people choose?

mkalisz77 commented 3 years ago

I'm not Symfony master, one possibility is to have it in another new Trait.

TomasVotruba commented 3 years ago

We'll need tests to make sure it works. Would you like to add it?

mkalisz77 commented 3 years ago

Hi, I've prepared PR for using ULID from Symfony.

TomasVotruba commented 2 years ago

Hi, I'm going through old opended issues and PRs to cleanup too-long-opened items and close them. Thank you for your contribution and time.

We needs a feature with test and passing CI to be able to merge it without letting a bug in. If this is still relevant for you, please add code with test and make CI pass first. Then we'll able to merge your feature without further waiting :+1:

Thank for understanding.