search

KnpLabs / DoctrineBehaviors

Doctrine2 behavior traits that help handling Blameable, Loggable, Sluggable, SoftDeletable, Uuidable, Timestampable, Translatable, Tree behavior
http://knplabs.com
MIT License
911 stars 287 forks source link

fix: compatibility with TreeNodeInterface #636

Closed netbull closed 2 years ago

netbull commented 3 years ago

Anyone? Is this project dead?

Kocal commented 3 years ago

Hi, the project is not dead, @TomasVotruba is just busy with something else.

But I think you can start to make the CI green! :)

netbull commented 3 years ago

@Kocal this is not serious..

I know that people are busy, not only @TomasVotruba and in the open source world if something does not work fix it yourself. That's what I did, the Tree does not work because of compatibility issues of the Interface. The fix is quite simple and I did it..

A long as the "make the CI green" is concerned, the only thing which is failing is the CS which is totally not related with this PR and the code which I submitted.

Kocal commented 3 years ago

That's how free and open-source work, Tomas does not owe anything to us.

If it's urgent for you, you can use your own fork instead.

netbull commented 3 years ago

@Kocal I don't get it really.. There was an issue with this bundle, I submitted a fix. So I spent my time to do the fix and 19 days so far the code is not merged..

Don't get me wrong I don't need this anyway and I'm not on a rush. Just explain to someone else how the open-source works.

TomasVotruba commented 2 years ago

@netbull Thank you for pull-request :+1: I've probably missed this in amount of open-source notifications I'm getting. I'm sorry about that.

I've just updated to PHPStan Symplify rule sets, that include a rule that checks exactly this types conflitcs with traits/classes/interfaces: https://github.com/symplify/phpstan-rules/blob/main/docs/rules_overview.md#checkparentchildmethodparametertypecompatiblerule

Saying that, I've fixed this ~30 minutes ago and released in 2.3.0: https://github.com/KnpLabs/DoctrineBehaviors/commit/35ba29cefdfa18778f5273e1dc7c156f43d92340#diff-b02f17f75334fed0fdfe5a8777457e2e429c746224a9f7c2b661b3588eeb9819

@Kocal Thank you for support here :heart:

netbull commented 2 years ago

@TomasVotruba don't worry :) Thank you!