search

KnpLabs / DoctrineBehaviors

Doctrine2 behavior traits that help handling Blameable, Loggable, Sluggable, SoftDeletable, Uuidable, Timestampable, Translatable, Tree behavior
http://knplabs.com
MIT License
911 stars 287 forks source link

Can we have a tag 2.2.1 (for PHP 7.4) with the commit specified in the description ? #668

Closed grizzlylab closed 2 years ago

grizzlylab commented 2 years ago

https://github.com/KnpLabs/DoctrineBehaviors/commit/c5f6be71278e459e54d565bf91a455e695bc60b1

grizzlylab commented 2 years ago

@TomasVotruba When I added this fix, it was available for PHP 7.4, a few weeks ago, some things changed and I had to specify 2.2.0 in my composer.json as our project is still on PHP 7.4. What I didn't realize is that this last version available for PHP 7.4 does not contain the fix (it was possible before to have this fix with php 7.4).

Would you agree to release a tag for release 2.2.1 with the fix as PHP 7.4 is still officially supported (https://www.php.net/supported-versions.php).

Thank you very much in advance.

grizzlylab commented 2 years ago

@TomasVotruba To be honest, I was probably on master after the merge of the fix, then master required PHP8 (before 7.4 was ok), and then I went back on 2.2 without checking if the fix was in it. Would you agree to keep maintaining the 2.2 for PHP 7.4 (until EOL) users ? I know this is on your free time and you probably receive a lot of requests across all your projects but it would be very cool if we could continue to use this repository instead of a fork. Thank you very much :)

TomasVotruba commented 2 years ago

Hi, I don't have much time to maintain this. So only PHP 8+ is supported.

If you can contribute automated downgrade workflow to Github Actions, that would be a way to go for any future bumps :)

grizzlylab commented 2 years ago

@TomasVotruba Thank you for your feedback. I understand your point. I close this.

TomasVotruba commented 2 years ago

@grizzlylab Thank you for understanding.

If need help with @rectorphp to upgrade your code base, let me know. It's an easy pick :+1: